Updates to headers alignment #4473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6ee84ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Fercas123
force-pushed
the
headers-update
branch
from
c380946 to
9a44869
Compare
Fercas123
force-pushed
the
headers-update
branch
from
9a44869 to
74d9d3a
Compare
joshwooding
reviewed
Dec 16, 2024
joshwooding
reviewed
Dec 16, 2024
joshwooding
reviewed
Dec 18, 2024
joshwooding
reviewed
Dec 18, 2024
joshwooding
reviewed
Dec 18, 2024
joshwooding
reviewed
Dec 18, 2024
Fercas123
force-pushed
the
headers-update
branch
from
4e8f42e to
120c637
Compare
amritadesmet
previously approved these changes
Dec 20, 2024
Fercas123
force-pushed
the
headers-update
branch
from
f87436d to
a0541fe
Compare
joshwooding
approved these changes
Jan 14, 2025
joshwooding
reviewed
Jan 14, 2025
Fercas123
force-pushed
the
headers-update
branch
from
a0541fe to
38fe6c9
Compare
joshwooding
approved these changes
Jan 20, 2025
joshwooding
force-pushed
the
headers-update
branch
from
38fe6c9 to
86a0f63
Compare
joshwooding
added
the
chromatic
github-actions
bot
removed
the
chromatic
joshwooding
force-pushed
the
headers-update
branch
from
86a0f63 to
6ee84ca
Compare
chrispcode
approved these changes
Jan 21, 2025
chrispcode
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
The PR looks great, awesome to see simplifying a component!
Minor comment / Personal opinion: I think the name of a story and the title of the story should match. In the sense that If the set title is Lab/Dialog Header the the file should also be named something along the lines of lab/[dialog]/dialog-header.stories.tsx
joshwooding
added
the
chromatic
github-actions
bot
removed
the
chromatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix alignment for titles spanning into multiple lines, wrap dialog header in H2 to avoid breaking change